Skip to content

docs: name all three too-large caps in [email protected] error-code#21

Merged
joshuajbouw merged 1 commit into
mainfrom
fix/process-1.1-too-large-doc
Jul 2, 2026
Merged

docs: name all three too-large caps in [email protected] error-code#21
joshuajbouw merged 1 commit into
mainfrom
fix/process-1.1-too-large-doc

Conversation

@joshuajbouw

Copy link
Copy Markdown
Contributor

Summary

error-code.too-large in [email protected] only documented the 1 MiB per-call write-stdin cap, but the host also rejects a spawn-request.stdin prelude over 4 MiB (cumulative per spawn) with too-large — the record field says so, the error enum didn't. Flagged by review on sdk-rust#62.

Docs-only: no structural change to the frozen contract, so no linker impact. [email protected] is untouched — it stays byte-frozen as published.

https://claude.ai/code/session_01NvX2tE7tgXuCRevqqiXTGU

The doc only mentioned the 1 MiB per-call write-stdin cap, but the
host also rejects a spawn-request.stdin prelude over 4 MiB with
too-large. Docs-only; no structural change to the frozen contract.
[email protected] is untouched (byte-frozen as published).
Copilot AI review requested due to automatic review settings July 2, 2026 20:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation comment for the too-large error in the host/[email protected] interface. The description now explicitly details the applicable payload caps, including the 4 MiB spawn-request.stdin prelude, the 1 MiB per-call write-stdin limit, and the cumulative per-process write quota. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the WIT interface documentation for astrid:[email protected] to better describe when error-code.too-large is returned, aligning the enum docs with the documented stdin payload caps.

Changes:

  • Expands error-code.too-large documentation to enumerate the spawn-request.stdin prelude cap, write-stdin cap, and cumulative per-process quota.
  • Clarifies that the 4 MiB stdin cap is per-spawn (cumulative) for the spawn-request.stdin prelude.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread host/[email protected]
Comment on lines +69 to +72
/// Payload exceeded the applicable cap: the 4 MiB
/// `spawn-request.stdin` prelude (per spawn, cumulative), the
/// 1 MiB per-call `write-stdin` limit, or the cumulative
/// per-process write quota.
@joshuajbouw joshuajbouw merged commit a268eb3 into main Jul 2, 2026
2 checks passed
@joshuajbouw joshuajbouw deleted the fix/process-1.1-too-large-doc branch July 2, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants